-
Notifications
You must be signed in to change notification settings - Fork 9
Capture D1 cols 100-101 (school class in HS exports) #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | |||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -29,6 +29,9 @@ def d1_parser( | ||||||||||||||||||||||||||
| # unparsed_d1_col_125: col 125 (1 char). Observed: 'N' or blank; semantics unverified. | |||||||||||||||||||||||||||
| swimmer.citizenship = extract(line, 113, 3) or None | |||||||||||||||||||||||||||
| swimmer.unparsed_d1_col_125 = extract(line, 125, 1) or None | |||||||||||||||||||||||||||
| # unparsed_d1_col_100: cols 100-101 (2 chars). "Fr"/"So"/"Jr"/"Sr" school | |||||||||||||||||||||||||||
| # class in HS-meet exports; other data / blank in club exports. | |||||||||||||||||||||||||||
| swimmer.unparsed_d1_col_100 = extract(line, 100, 2) or None | |||||||||||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just verified. This field is called "Class Year" in the Meet Manager GUI.
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes I thought in naming it that, but it is not a 100% class_year, for non HS meets it shows other data. We can keep it class_year if you prefer.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here's the breakdown — D1 cols 100–101 across my hy3 files (~9.5M records):
|
|||||||||||||||||||||||||||
|
|
|||||||||||||||||||||||||||
| swimmer.team_code = team_code | |||||||||||||||||||||||||||
|
|
|||||||||||||||||||||||||||
|
|
|||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some digging on this, every file I have has it set to
N.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I couldn't find figure out what is the N in some meets.