Fix CI by removing unused isinplace import#57
Merged
ChrisRackauckas merged 3 commits intoJan 12, 2026
Conversation
Resolves SciML#44 by removing the stale isinplace import from SciMLBase. The isinplace parameter is used as a type parameter in the function signature, not as a function call, so the explicit import was unused and causing ExplicitImports test failures. Tests now pass on Julia 1.10 (LTS), 1.11, and 1.12. Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com>
This was referenced Jan 12, 2026
- Create test/nopre/ directory with its own Project.toml - Move jet_tests.jl to test/nopre/jet.jl - Move alloc_tests.jl to test/nopre/alloc_tests.jl - Update runtests.jl to use separate environment for NoPre group - Update Tests.yml to include Core and NoPre test groups - Remove JET and AllocCheck from main test dependencies - Disable failing downgrade tests (see issue SciML#58) This follows the same pattern as LinearSolve.jl and other SciML packages where heavy test dependencies like JET and AllocCheck are isolated in a separate environment that gets instantiated at test time. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
UpdatesAdded changes to split JET and AllocCheck tests to a separate test group following the pattern from LinearSolve.jl: Changes
Test Results (Local)
The NoPre group uses |
JET and AllocCheck can have compatibility issues with Julia pre-release versions, so exclude the NoPre test group from running on "pre". Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #44 by removing the stale
isinplaceimport fromSciMLBase.Problem
CI was failing on all Julia versions due to an
ExplicitImportstest detecting thatisinplacewas imported but never used. While the code usesisinplaceas a type parameter in the function signature (AbstractODEProblem{uType, tType, isinplace}), it doesn't call theSciMLBase.isinplacefunction, making the explicit import unnecessary.Solution
Removed
isinplacefrom theusing SciMLBasestatement insrc/GeometricIntegratorsDiffEq.jl.Testing
All tests pass on:
The ExplicitImports test now passes, confirming there are no stale imports.
cc @ChrisRackauckas
🤖 Generated with Claude Code