Add option for enabling threaded loading

[XenuIsWatching]

Add a option in the "other settings" to enable threaded gamelist loading. This option already existed in es_settings, there just wasn't an easy to set it without manually editing the file
This gives better performance when parsing multiple large gamelists, and will give a much faster start up time

threaded-loading.-.Made.with.Clipchamp.mp4

[pjft]

Thanks for sending this over. There seem to be more changes than just the option being added. Can you elaborate on them?

[XenuIsWatching]

Thanks for sending this over. There seem to be more changes than just the option being added. Can you elaborate on them?

That is just getting the 'Loading screen' working with the progress bar being updated with multiple threads. There was some work to get that also displaying vertically where it will list out each platform is scanning for each thread.

[pjft]

I tested it and it looks good from my end.

If nobody else has any concerns, I'm happy to merge.

[cmitu]

I'm not a fan of displaying multiple systems at once during loading, but that's subjective.
As long as the default option is kept the same (i.e. off), it's ok with me 👍.

[pjft]

I agree with that take.
When Threaded Loading is on, it now shows all systems like that - whereas in the previous version it only showed one.
I'd agree with either splitting the PRs, or reverting that part.

[XenuIsWatching]

I can split it, but I don't really agree with the decisions here (but it's subjective as well here...). I know I left the 'default' to be off here, but i'd argue it should be 'on' by default (and this how bactocera has it as well), as I can't think any reason for it to 'not' be on, as a multi-threaded load is just superior in every which way (no drawbacks)... but this isn't too big of a deal for me as I'll just manually go turn it on 'everytime'.

As for displaying 'multiple' systems being loaded in 'parallel' here, i think showing all the systems being loaded at once here is the way to go... as well that is what it is doing (not just loading the one at the time here)

Anyways... I'll get to splitting this later this weekend. Trivial thing to do here but it's a holiday weekend in the USA here, and very difficult to get to my 'work room' with all the events going on right now

[pjft]

No worries. Enjoy your holiday!

[XenuIsWatching]

This has been split to now just be the first commit from before

The latter commit was split to #911

[cmitu]

I know I left the 'default' to be off here, but i'd argue it should be 'on' by default (and this how bactocera has it as well), as I can't think any reason for it to 'not' be on, as a multi-threaded load is just superior in every which way (no drawbacks)... but this isn't too big of a deal for me as I'll just manually go turn it on 'everytime'.

The reason the default is 'off' was that - after it has been introduced with the default to 'on' - it was reported by users in the forum that it led to ES crashing on start.