Make output of note commands private

[pmayd]

We noticed that right now, when you use any of the note commands like @Karmabot note list the output is visible to anyone/others in the same channel (pybob used the command, I could make the screenshot):

This behavior is not intended, because it both is a privacy violation and increases the overall noise in the channels (something karmabot loves to do).

My proposed solution would be to move these messages into a private chat, so basically turn the output of these commands into DMs for the user.

[pogross]

Easy fix would be to move the note command registration from CHANNEL_BOT_COMMANDS to DM_BOT_COMMANDS.

karmabot/src/karmabot/bot.py

Lines 43 to 61 in 70c8a32

	CHANNEL_BOT_COMMANDS = {
	"add": add_command,
	"age": pybites_age,
	"joke": joke,
	"note": note,
	"tip": get_random_tip,
	"topchannels": get_recommended_channels,
	"zen": import_this,
	}
	DM_BOT_COMMANDS = {
	"doc": doc_command,
	"feed": get_pybites_last_entries,
	"joke": joke,
	"note": note,
	"karma": get_karma,
	"topchannels": get_recommended_channels,
	"username": get_user_name,
	"updateusername": update_username,
	}

[bbelderbos]

I like that idea, this feature does not seem to have any business being used in channels :) - no?