chore(app): address terminal preview review comments

Author: rikohomeless

packages/app/src/web/terminal-inline-images-core.ts

@@ -53,6 +53,27 @@ export const splitTerminalInlineImageOutput = (
   return segments
 }
 
+/**
+ * Coordinates terminal output writes for one parsed segment.
+ *
+ * This function only sequences the supplied writer callbacks. It does not fetch
+ * image data, allocate decorations, or mutate terminal state directly; those
+ * effects belong to the writer implementation.
+ *
+ * @pure false - invokes effectful writer callbacks.
+ * @effect writer callbacks: writeText, writePreviewLineBreak, writePreviews.
+ * @precondition segment is the next queued terminal output segment and
+ * onComplete belongs to the caller's active output queue drain.
+ * @postcondition writeText is requested exactly once; when previews are enabled
+ * and imagePaths is non-empty, the preview line break and preview writes are
+ * requested in order before onComplete.
+ * @invariant segment.text is emitted before any preview callback, and preview
+ * callbacks never run when imagePaths is empty or previews are disabled.
+ * @complexity O(1) plus writer callback complexity; image paths are forwarded
+ * without iteration.
+ * @throws Through writer callbacks or onComplete only; this function has no
+ * explicit throw path.
+ */
 export const writeTerminalOutputSegment = (
   { inlineImagePreviewsEnabledRef, segment, writer }: TerminalOutputSegmentWriteArgs,
   onComplete: () => void

packages/app/src/web/terminal-panel-runtime.ts

@@ -227,7 +227,6 @@ export const useTerminalSessionLifecycle = (
   }, [
     connectionRef,
     hostRef,
-    inlineImagePreviewsEnabledRef,
     notifyMessage,
     onAttachFailure,
     runtimeRef,