Skip to content

pull_request_template.md

Latest commit

 

History

History
117 lines (85 loc) · 3.29 KB

pull_request_template.md

File metadata and controls

117 lines (85 loc) · 3.29 KB
Raw

Summary

Area

  • Web UI / frontend
  • Agent / loop / delegation
  • Kernel / host RPC / runtime
  • Server / gateway / API
  • Store / provenance / artifacts
  • Skills / science runtime
  • Compute / remote execution
  • CLI / config / packaging
  • Tests / harness / CI
  • Docs

Change Type

  • Bug fix
  • Feature
  • Refactor
  • Test / harness
  • Documentation
  • Security-related change
  • Release / packaging

Verification

Ran:

Not run:

Reason:

Risk and Reviewer Focus

Checklist

Diff Readiness

  • I reviewed and understand the full diff.
  • This PR is small and single-purpose.
  • No unrelated formatting, broad rewrite, or drive-by refactor is included.
  • Hotspot files were edited surgically if touched: gateway.py, host_dispatch.py, store.py, worker.py, manager.py.
  • Workbench changes were made in frontend/ (not legacy app.js) and openai4s/server/webui/dist/ was rebuilt and committed with the source. OPENAI4S_WEBUI=legacy is an escape hatch, not a place to add features.
  • openai4s/server/webui/vendor/ and tests/fixtures/ were not reformatted.

Tests

  • Relevant tests or manual checks were run and listed above.
  • No new test requires live LLM, network, GPU, SSH, Docker, lab hardware, or secrets in the default offline suite.
  • No tests were deleted without tracked replacements.
  • Kernel / host-RPC / gateway changes include focused contract coverage or a documented smoke test.

Core Dependency Policy

  • No hard third-party import was added to the core engine, LLM client, or stdlib web server.
  • Optional science imports are guarded by try/except ImportError at every in-tree use site.
  • New dependencies, if any, are documented and justified.

Public Disclosure and Security

  • No secrets, API keys, tokens, real credentials, private data, model weights, or local absolute paths are included.
  • No unpublished research roadmap, internal assignment, benchmark detail, or unreleased experimental result is disclosed.
  • Security-sensitive changes include appropriate synthetic tests or manual verification notes.
  • Docs do not overstate isolation, sandboxing, privacy, or security guarantees.

Docs

  • Docs match actual code behavior.
  • User-facing behavior changes are reflected in docs or release notes where appropriate.
  • README.md and README_zh.md stay in sync where translated sections are affected.