Skip to content

MathHelper.floor bad parameter name #215

Description

@uRyanxD

Type
Parameter

Describe where the element is
MathHelper.floor that the method AnimalEntity#canSpawn() uses
1.8.9 mappings (the other mappings likely use the same names for the method parameters)

Description of the element
Returns the largest integer less than or equal to the provided value

Expected name
value or d or double

Additional Context
Currently, the parameter is named "x" which causes IJ to display warnings like this: https://prnt.sc/5GJLynw3jJyl
Several other methods in this class with a single parameter also use "x" so the issue likely occurs with their usages as well; however, there are too many methods and usages to check. The sin and cos methods could also use "angle" for example; ultimately, reviewing the parameter names for all methods in this class would be a good idea.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions