Does player.ship ever not exist?

[LinuxOnTheDesktop]

Dear all

I am wondering whether some of the checks in the following - which occurs within a repopulator Javascript function - are redundant.

if (!player.ship || !player.ship.isValid || !player.ship.position) return;

Thanks.

[phkb]

In my testing, player.ship should always exist. However, isValid can be true, at one point, and false almost a frame later. For example, add this code to a world script:

this.shipTakingDamage = function(amount, whom, type) {
	log(this.name, "shipTakingDamage");
	log(this.name, "player ship " + (player.ship ? "exists" : "does not exist"));
	log(this.name, "player.ship.isValid = " + player.ship.isValid);
	log(this.name, "player.ship.position " + (player.ship.position ? "is valid" : "is not valid"));
}
this.shipDied = function() {
	log(this.name, "shipDied");
	log(this.name, "player ship " + (player.ship ? "exists" : "does not exist"));
	log(this.name, "player.ship.isValid = " + player.ship.isValid);
	log(this.name, "player.ship.position " + (player.ship.position ? "is valid" : "is not valid"));
}

Then start a new game, launch, then spin around a ram the station for an instant death. Then check your log file. This is what I see:

09:22:23.323 [Testscript]: shipTakingDamage
09:22:23.323 [Testscript]: player ship exists
09:22:23.323 [Testscript]: player.ship.isValid = true
09:22:23.324 [Testscript]: player.ship.position is valid
09:22:23.326 [Testscript]: shipDied
09:22:23.326 [Testscript]: player ship exists
09:22:23.327 [Testscript]: player.ship.isValid = false
09:22:23.327 [Testscript]: player.ship.position is valid

So, during the shipTakingDamage event, the player ship is valid, even though the event is literally killing the player. But in shipDied, the player ship isn't valid any more.

As for player.ship.position, in one run of that test, I got no other errors in the log. But in the last instance, I saw this:

09:22:27.069 [script.javaScript.exception.unexpectedType]: ***** JavaScript exception (station_ads_station_script 1.2): TypeError: player.ship.position is undefined
09:22:27.069 [script.javaScript.exception.unexpectedType]: ../AddOns/Mechanics.oxp/StationDockControl.oxp/Scripts/stationdockcontrol.js, line 1295.

What has happened here, is that another worldscript or ship script event has fired after the player ship died. I have seen similar errors coming from the Custom Shields mod. So, player.ship.position can be undefined in some circumstances, generally speaking during events that aren't directly linked to player actions (repopulator functions, ship script events, timer functions, that sort of thing). However, player.ship.isValid should be false at the same time that player.ship.position is undefined.

Hopefully that all makes sense.

[LinuxOnTheDesktop]

Great stuff. Thank you very much.