Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 906bd83 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
| setNetwork("mainnet") | ||
| expect(addresses.near.contract).toBe("omni.bridge.near") | ||
| expect(addresses.near.rpcUrls).toEqual(["https://rpc.near.org"]) | ||
| expect(addresses.near.rpcUrls).toEqual(["https://free.rpc.fastnear.com"]) |
There was a problem hiding this comment.
Mainnet RPC behavior remains untested
This assertion checks the new URL string, but it does not exercise the mainnet FastNEAR endpoint or the wallet-selector view calls whose latency motivates the change. The existing live decimals test covers testnet only. A slow or incompatible mainnet endpoint could therefore pass the suite unnoticed; please add coverage for the mainnet RPC path and the relevant wallet-selector calls.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Backports the RPC change from 7a2c620 (already on main) to the legacy
omni-bridge-sdkrelease branch.https://rpc.near.org→https://free.rpc.fastnear.comhttps://rpc.testnet.near.org→https://test.rpc.fastnear.comomni-bridge-sdkNearWalletSelectorBridgeClientmakes view calls (balances, storage) throughaddresses.near.rpcUrlsbeforesignAndSendTransaction(s). Onrpc.near.orgeach call takes ~3s (vs ~0.2s on FastNEAR), which pushes the wallet popup outside the user-gesture window, so browsers block it.