fix(cli): preserve existing directories during single-file upload (#4177)

* fix(cli): preserve existing directories during single-file upload

Inspect remote destination types before choosing archive entry names.
Keep directory and source symlinks intact, recheck detected type changes,
and report the resulting path. Add real tar and live conformance coverage.

Closes #4175

Signed-off-by: Shiju <shiju@nvidia.com>

* fix(cli): box upload future in sandbox_create

Boxing the upload future keeps the sandbox_create future under the clippy::large_futures threshold after sandbox_upload_planned began returning the uploaded path.

Signed-off-by: Shiju <shiju@nvidia.com>

---------

Signed-off-by: Shiju <shiju@nvidia.com>

Author: shiju-nv

crates/openshell-cli/src/main.rs

@@ -1781,7 +1781,11 @@ enum SandboxCommands {
         #[arg(value_hint = ValueHint::AnyPath)]
         local_path: String,
 
-        /// Destination path in the sandbox (defaults to the container's working directory).
+        /// Destination path in the sandbox (defaults to its working directory).
+        ///
+        /// For an unfiltered single-file upload, an existing directory or a
+        /// trailing slash places the file inside that directory. A missing
+        /// nested path without a trailing slash renames the file.
         dest: Option<String>,
 
         /// Disable `.gitignore` filtering (uploads everything).

crates/openshell-cli/src/run.rs

@@ -1060,15 +1060,17 @@ pub async fn sandbox_create(
                         "\u{2022}".dimmed(),
                     );
                 }
-                sandbox_upload_planned(
+                // Boxed so the upload state machine lives on the heap instead of
+                // inflating the `sandbox_create` future (clippy::large_futures).
+                Box::pin(sandbox_upload_planned(
                     upload_plan,
                     &effective_server,
                     &sandbox_name,
                     Path::new(local_path),
                     dest,
                     &effective_tls,
                     workspace,
-                )
+                ))
                 .await
                 .wrap_err_with(|| {
                     format!(
@@ -5110,7 +5112,7 @@ async fn sandbox_upload_planned(
     sandbox_path: Option<&str>,
     tls: &TlsOptions,
     workspace: &str,
-) -> Result<()> {
+) -> Result<Option<String>> {
     match plan {
         SandboxUploadPlan::GitAware { base_dir, files } => {
             sandbox_sync_up_files(
@@ -5123,10 +5125,13 @@ async fn sandbox_upload_planned(
                 tls,
                 workspace,
             )
-            .await
+            .await?;
+            Ok(None)
         }
         SandboxUploadPlan::Regular => {
-            sandbox_sync_up(server, name, local_path, sandbox_path, tls, workspace).await
+            sandbox_sync_up(server, name, local_path, sandbox_path, tls, workspace)
+                .await
+                .map(Some)
         }
     }
 }
@@ -5152,7 +5157,7 @@ pub async fn sandbox_upload(
         dest_display
     );
 
-    sandbox_upload_planned(
+    let uploaded_path = sandbox_upload_planned(
         upload_plan,
         server,
         name,
@@ -5163,7 +5168,11 @@ pub async fn sandbox_upload(
     )
     .await?;
 
-    eprintln!("{} Upload complete", "✓".green().bold());
+    if let Some(path) = uploaded_path {
+        eprintln!("{} Upload complete: {path}", "✓".green().bold());
+    } else {
+        eprintln!("{} Upload complete", "✓".green().bold());
+    }
     Ok(())
 }