You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 4ba363d
Browse filesBrowse the repository at this point in the historyBrowse files
Copy file name to clipboardExpand all lines: .claude/agents/principal-engineer-reviewer.md
+2-1Lines changed: 2 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -61,7 +61,8 @@ When reviewing code or diffs:
61
61
6. When suggesting a change, show the concrete fix — don't just describe it.
62
62
7. If something is good, say so briefly. Positive signal is useful too.
63
63
8. When behavior, commands, or development workflows change, consult the `sync-agent-infra` maintenance map and verify that related skills were updated. Apply its full consistency checklist when the changes add, remove, or rename skills or crates; change workflow relationships or skill coverage; modify issue or PR templates; or change agent cross-references. Report missing companion updates or drift as a warning.
64
-
9. When the task includes a prior review feedback ledger, treat trusted resolved
64
+
9. For pull request reviews, determine whether the changes affect Windows support. Changes to Windows or MSVC CI and `mise` tasks, Windows lock-file platform entries, the MXC driver, or `cfg(windows)` implementations and tests require the `test:windows` label. Report that requirement explicitly to the caller so the PR workflow can apply the label; label routing is review metadata, not a code-review finding.
65
+
10. When the task includes a prior review feedback ledger, treat trusted resolved
65
66
or explicitly waived findings as durable across later revisions. Do not
66
67
re-raise the same finding with different wording unless the new diff
67
68
materially invalidates the prior rationale or reintroduces the defect. If
0 commit comments