Skip to content

Commit 41e019c

Browse files
committed
fix(docker): resolve rebase regressions
Signed-off-by: Evan Lezar <elezar@nvidia.com>
1 parent 8e6f079 commit 41e019c

2 files changed

Lines changed: 7 additions & 13 deletions

File tree

‎crates/openshell-driver-docker/src/lib.rs‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ use openshell_core::proto_struct::{
5959
use openshell_core::{Error, Result as CoreResult};
6060
use opentelemetry::trace::TraceContextExt as _;
6161
use std::collections::{HashMap, HashSet};
62-
use std::future::Future;
6362
use std::net::{IpAddr, Ipv4Addr, SocketAddr};
6463
use std::path::{Path, PathBuf};
6564
use std::pin::Pin;
@@ -978,12 +977,6 @@ impl DockerComputeDriver {
978977
image.ref = %template.image,
979978
))
980979
.await?;
981-
let token_file_created = write_sandbox_token_file(sandbox, &self.config)
982-
.await
983-
.map_err(|status| {
984-
DockerProvisioningFailure::new("SandboxTokenWriteFailed", status.message())
985-
})?;
986-
987980
let container_name = container_name_for_sandbox(sandbox);
988981
let gpu_devices = self
989982
.resolve_gpu_cdi_devices(

‎crates/openshell-driver-docker/src/tests.rs‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ async fn standalone_traced_client() -> (
238238
let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await.unwrap();
239239
let address = listener.local_addr().unwrap();
240240
let (shutdown, shutdown_rx) = tokio::sync::oneshot::channel();
241-
let service = ComputeDriverService::new(test_driver_with_config(runtime_config()));
241+
let service = ComputeDriverService::new(test_driver_with_config(runtime_config(false)));
242242
let server = tokio::spawn(async move {
243243
tonic::transport::Server::builder()
244244
.layer(openshell_otel::compute_driver_rpc_layer())
@@ -346,7 +346,8 @@ async fn tracing_in_process_service_preserves_the_driver_rpc_server_boundary() {
346346
otel_tracing::TRACING.in_process_targets(),
347347
))
348348
.with(otel_tracing::TRACING.in_process_layer(&driver_provider));
349-
let service = ComputeDriverService::new_in_process(test_driver_with_config(runtime_config()));
349+
let service =
350+
ComputeDriverService::new_in_process(test_driver_with_config(runtime_config(false)));
350351

351352
async {
352353
let gateway_span = tracing::info_span!(
@@ -486,7 +487,7 @@ async fn tracing_lifecycle_rpc_failures_export_docker_operation_spans() {
486487
.with_simple_exporter(exporter.clone())
487488
.build();
488489
let subscriber = tracing_subscriber::registry().with(otel_tracing::TRACING.layer(&provider));
489-
let driver = test_driver_with_config(runtime_config());
490+
let driver = test_driver_with_config(runtime_config(false));
490491

491492
async {
492493
ComputeDriver::create_sandbox(
@@ -540,7 +541,7 @@ async fn tracing_direct_start_exports_a_docker_start_span() {
540541
.with_simple_exporter(exporter.clone())
541542
.build();
542543
let subscriber = tracing_subscriber::registry().with(otel_tracing::TRACING.layer(&provider));
543-
let driver = test_driver_with_config(runtime_config());
544+
let driver = test_driver_with_config(runtime_config(false));
544545

545546
DockerComputeDriver::start_sandbox(&driver, "", "")
546547
.with_subscriber(subscriber)
@@ -572,7 +573,7 @@ async fn tracing_image_preparation_failure_exports_nested_failed_spans() {
572573
.with_simple_exporter(exporter.clone())
573574
.build();
574575
let subscriber = tracing_subscriber::registry().with(otel_tracing::TRACING.layer(&provider));
575-
let mut config = runtime_config();
576+
let mut config = runtime_config(false);
576577
config.image_pull_policy = "unsupported".to_string();
577578
let driver = test_driver_with_config(config);
578579

@@ -1284,7 +1285,7 @@ fn build_environment_keeps_network_capabilities_driver_controlled() {
12841285
openshell_core::sandbox_env::NETWORK_RUNTIME_CAPABILITIES.to_string(),
12851286
"spoofed".to_string(),
12861287
);
1287-
let env = build_environment(&sandbox, &runtime_config());
1288+
let env = build_environment(&sandbox, &runtime_config(false), false);
12881289
assert!(env.contains(&format!(
12891290
"{}={}",
12901291
openshell_core::sandbox_env::NETWORK_RUNTIME_CAPABILITIES,

0 commit comments

Comments
 (0)