refactor(conformance): remove unused CLI scenario APIs

Signed-off-by: Evan Lezar <elezar@nvidia.com>

Author: elezar

crates/openshell-conformance/src/lib.rs

@@ -25,16 +25,15 @@ use self::executor::{CliExecutionError, CliExecutor, ProcessCli};
 
 pub use scenarios::{
     FILE_TRANSFER_GIT_FILTERING_SCENARIO, FILE_TRANSFER_PATH_SAFETY_SCENARIO,
-    FILE_TRANSFER_ROUND_TRIP_SCENARIO, FILE_TRANSFER_SCENARIO, MECHANISTIC_PROPOSAL_SCENARIO,
+    FILE_TRANSFER_ROUND_TRIP_SCENARIO, MECHANISTIC_PROPOSAL_SCENARIO,
     NEW_HOSTNAME_PROPOSAL_SCENARIO, POLICY_LOCAL_SCENARIO, SANDBOX_LIFECYCLE_SCENARIO,
     SMOKE_SCENARIO,
 };
 
-/// An installed conformance scenario.
+/// A portable conformance scenario exercised by the Cargo test suite.
 #[derive(Debug)]
 pub struct Scenario {
     pub name: &'static str,
-    pub description: &'static str,
     run: for<'a> fn(&'a mut OpenShellRunner) -> ScenarioFuture<'a>,
 }
 
@@ -46,25 +45,6 @@ impl Scenario {
     }
 }
 
-const SCENARIOS: &[Scenario] = &[
-    SMOKE_SCENARIO,
-    SANDBOX_LIFECYCLE_SCENARIO,
-    FILE_TRANSFER_SCENARIO,
-    MECHANISTIC_PROPOSAL_SCENARIO,
-    NEW_HOSTNAME_PROPOSAL_SCENARIO,
-    POLICY_LOCAL_SCENARIO,
-];
-
-/// Returns every scenario compiled into this distribution.
-pub fn scenarios() -> &'static [Scenario] {
-    SCENARIOS
-}
-
-/// Finds a scenario by its stable command-line name.
-pub fn scenario(name: &str) -> Option<&'static Scenario> {
-    scenarios().iter().find(|candidate| candidate.name == name)
-}
-
 const CLEANUP_TIMEOUT: Duration = Duration::from_mins(2);
 pub const STATUS_TIMEOUT: Duration = Duration::from_secs(30);
 const GATEWAY_STATUS_ATTEMPT_TIMEOUT: Duration = Duration::from_secs(10);
@@ -281,13 +261,6 @@ pub struct OpenShellCommand<'a> {
 }
 
 impl OpenShellRunner {
-    pub fn new(scenario: &str) -> Result<Self, RunnerError> {
-        Ok(Self::with_executor(
-            Arc::new(ProcessCli::new(PathBuf::from("openshell"))),
-            scenario,
-        ))
-    }
-
     /// Uses an explicit `openshell` binary rather than resolving it on `PATH`.
     pub fn with_binary(binary: PathBuf, scenario: &str) -> Result<Self, RunnerError> {
         if !binary.is_file() {
@@ -335,10 +308,6 @@ impl OpenShellRunner {
         &self.run_id
     }
 
-    pub fn scenario(&self) -> &str {
-        &self.scenario
-    }
-
     pub fn step(&self, step: impl Into<String>) -> CommandStep<'_> {
         CommandStep {
             runner: self,
@@ -871,7 +840,6 @@ mod tests {
         let (mut runner, _cli) = test_runner(Vec::new());
 
         assert_eq!(runner.id().len(), 10);
-        assert_eq!(runner.scenario(), "smoke");
         runner.finished = true;
     }
 

crates/openshell-conformance/src/scenarios/file_transfer.rs

@@ -17,42 +17,24 @@ const COMMAND_TIMEOUT: Duration = Duration::from_mins(2);
 const TRANSFER_TIMEOUT: Duration = Duration::from_mins(5);
 const LARGE_FILE_SIZE: usize = 512 * 1024;
 
-/// Certify portable upload and download behavior through the public CLI.
-pub const FILE_TRANSFER_SCENARIO: Scenario = Scenario {
-    name: "file-transfer",
-    description: "Verify sandbox uploads, downloads, Git filtering, and path safety.",
-    run: run_file_transfer,
-};
-
 /// Certify basic file and directory upload and download behavior.
 pub const FILE_TRANSFER_ROUND_TRIP_SCENARIO: Scenario = Scenario {
     name: "file-transfer/round-trip",
-    description: "Verify file and directory upload and download round trips.",
     run: run_round_trip,
 };
 
 /// Certify Git-aware upload filtering and explicit unfiltered uploads.
 pub const FILE_TRANSFER_GIT_FILTERING_SCENARIO: Scenario = Scenario {
     name: "file-transfer/git-filtering",
-    description: "Verify Git-aware upload selection and explicit unfiltered uploads.",
     run: run_git_filtering,
 };
 
 /// Certify file-transfer workspace boundary and filename safety behavior.
 pub const FILE_TRANSFER_PATH_SAFETY_SCENARIO: Scenario = Scenario {
     name: "file-transfer/path-safety",
-    description: "Verify workspace boundary enforcement and safe filename handling.",
     run: run_path_safety,
 };
 
-fn run_file_transfer(runner: &mut OpenShellRunner) -> ScenarioFuture<'_> {
-    Box::pin(async move {
-        FILE_TRANSFER_ROUND_TRIP_SCENARIO.run(runner).await?;
-        FILE_TRANSFER_GIT_FILTERING_SCENARIO.run(runner).await?;
-        FILE_TRANSFER_PATH_SAFETY_SCENARIO.run(runner).await
-    })
-}
-
 fn run_round_trip(runner: &mut OpenShellRunner) -> ScenarioFuture<'_> {
     Box::pin(async move {
         let (sandbox_name, remote_root, local) = prepare_sandbox(runner, "round-trip").await?;

crates/openshell-conformance/src/scenarios/mod.rs

@@ -1,7 +1,7 @@
 // SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
 // SPDX-License-Identifier: Apache-2.0
 
-//! Registered, portable conformance scenarios.
+//! Portable conformance scenarios exercised by the Cargo test suite.
 
 mod file_transfer;
 mod policy_behavior;
@@ -10,7 +10,7 @@ mod smoke;
 
 pub use file_transfer::{
     FILE_TRANSFER_GIT_FILTERING_SCENARIO, FILE_TRANSFER_PATH_SAFETY_SCENARIO,
-    FILE_TRANSFER_ROUND_TRIP_SCENARIO, FILE_TRANSFER_SCENARIO,
+    FILE_TRANSFER_ROUND_TRIP_SCENARIO,
 };
 pub use policy_behavior::{
     MECHANISTIC_PROPOSAL_SCENARIO, NEW_HOSTNAME_PROPOSAL_SCENARIO, POLICY_LOCAL_SCENARIO,

crates/openshell-conformance/src/scenarios/policy_behavior.rs

@@ -27,19 +27,16 @@ struct SandboxState {
 
 pub const POLICY_LOCAL_SCENARIO: Scenario = Scenario {
     name: "policy-local",
-    description: "Read and request a rule through the sandbox-local policy HTTP API.",
     run: run_policy_local,
 };
 
 pub const MECHANISTIC_PROPOSAL_SCENARIO: Scenario = Scenario {
     name: "mechanistic-proposal",
-    description: "Turn a denied transparent TCP open into a scoped policy draft.",
     run: run_mechanistic_proposal,
 };
 
 pub const NEW_HOSTNAME_PROPOSAL_SCENARIO: Scenario = Scenario {
     name: "new-hostname-proposal",
-    description: "Turn a denied TCP open to a hostname absent from policy into a scoped draft.",
     run: run_new_hostname_proposal,
 };
 

crates/openshell-conformance/src/scenarios/sandbox_lifecycle.rs

@@ -31,7 +31,6 @@ struct SandboxListPage {
 /// Certify sandbox stop, start, and deletion lifecycle behavior.
 pub const SANDBOX_LIFECYCLE_SCENARIO: Scenario = Scenario {
     name: "sandbox-lifecycle",
-    description: "Verify sandbox stop, start, and deletion lifecycle behavior.",
     run: run_sandbox_lifecycle,
 };
 

crates/openshell-conformance/src/scenarios/smoke.rs

@@ -31,7 +31,6 @@ struct SandboxListPage {
 /// Certify status -> create -> list Ready -> exec -> delete -> list empty.
 pub const SMOKE_SCENARIO: Scenario = Scenario {
     name: "smoke",
-    description: "Create, inspect, execute in, and delete a base sandbox.",
     run: run_smoke,
 };