Query parameters are lost in the listen example

[stc1988]

Build environment: macOS
Moddable SDK version: 9.5.0
Target device: desktop simulator

Description

In examples/io/listener/listen, query parameters are missing from request.url.

Steps to Reproduce

1. run examples/io/listener/listen
2. send request curl 'http://localhost/query?text=hello'

Expected behavior
request.url.searchParams.get("text") returns "hello".
Actual: It returns null, and request.url.search is empty.

Other information

The HTTP server separates the request target into path and query, but listen.js constructs the URL using only path:

https://github.com/Moddable-OpenSource/moddable/blob/public/examples/io/listener/listen/listen.js#L154-L155

[stc1988]

This appears to be caused by commit 8fab7da, which separated request.path and request.query.

However, examples/io/listener/listen/listen.js still constructs the URL using only path:

new URL(path, base)

Since path no longer includes the query string, query parameters are lost.

[phoddie]

True. The HTTP server change isn't compatible with existing code that depends on the query. The fix for listen should be straightforward, I think changing line 155 from...

const request = new Request(new URL(path, base), { method, path, headers, body:requestPromise });

...to:

const url = new URL(path, base);
url.search = request.query;
const request = new Request(url, { method, path, headers, body:requestPromise });

I can't try this at the moment. If you can, please let me know if it resolves the issue.

By the way, are you using listen.js in some project (Stack-chan)? I'm curious because we are still thinking about high-level HTTP server APIs.

[stc1988]

Thanks for checking. I’m looking into whether the proposed implementation will work well.

I’m working on a lightweight web application framework in the following project, aiming for something similar to Hono:
https://github.com/stc1988/moddable-http-server

Since many runtimes and frameworks use the Web-standard Request and Response APIs, I think it would be preferable to go in that direction.