Skip to content

ExactCalldataBatchEnforcer should pin terms target and value #198

Description

@SashaMIT

Summary

ExactCalldataBatchEnforcer terms are encoded as Execution[] (target, value, calldata), but beforeHook only compares calldata. A redeemer can reuse the same calldata against a different target (or attach native value).

Sibling enforcer ExactExecutionBatchEnforcer already pins the full execution. Single-call ExactCalldataEnforcer correctly treats terms as raw calldata only; the batch variant's terms ABI implies the fuller check.

Proposal

In the batch loop, also require target and value equality with the terms executions (fail closed), plus regression tests for target-swap and non-zero value.

Happy to open a PR against main.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions