Children where only one parent is listed

[rctneil]

Hi,

I've been testing this and DTree out. If I remove one parent from a child (to simulate not having the information available) and set parent2Id to null, the tree fails to render anything.

Is this the expected outcome?

[JMHeartley]

It should work, could you paste your data before it's processed by dSeeder?

[theTaikun]

I'm having the same issue. Problem seems to be because the case for either both parents or no parents is handled, but not properly handling the case when only 1 parent is specified and the other is null.

I've fixed the issue in the distributed version of the script, and will look into implementing the fix in the src of this repo. It doesn't yet work with dTree (seems that a spouse cannot be missing, but I have to look deeper into that codebase). Once I clean up the fix and ensure it works with dTree, I will submit a PR.

[JMHeartley]

@theTaikun thanks for the info and I appreciate the help

If the problem stems from dTree then you could add the "missing" parent and set the text for that node to "X's other parent" or some other placeholder text

Ofc PRs are welcome anytime 😊

[theTaikun]

I did some more testing and realized this issue is two-part.

1. In it's current state, dTree-Seed fails to execute if one parent is null, and the other parent is set.
2. Even if you manage to get seeded data with 1 null parent, this is incorrect for what dTree expects. For any single-parent children, the children array should be a direct descendant of the node, rather than nested within the marriages array. Source. That is, input data should be formatted like this:

   [
       {
           "name": "Father",
           "marriages": []
           "children": [
               {
                   "name": "Child",
               }
           ]
       }
   ]

I've been looking at other projects to fulfill my family tree needs, and I'm not sure I will continue working on this bug. For anyone in the future who is interested, I've lost the work I did to solve problem 1, so I will detail what I can recall doing.

If otherParentId is null, escape the function early by returning null after this section.

dTree-Seed/src/seeder.ts

Lines 51 to 55 in 9e16df8

	const otherParentIds = children.map((child) =>
	parentIds.includes(child.parent1Id as number)
	? child.parent2Id
	: child.parent1Id);

then bypass both these sections if the returned id is null

dTree-Seed/src/seeder.ts

Line 121 in 9e16df8

const otherParents = _getOtherParents(data, children, target);

dTree-Seed/src/seeder.ts

Lines 129 to 130 in 9e16df8

	const nextGenerationOtherParents = _getOtherParents(data, nextGenerationChildren, ...nextGeneration);
	members.push(...nextGenerationOtherParents);

This should at least get dTree-Seed to execute fully without error.

The next road I was going down to solve problem 2 was by creating a boolean "nuclear" that was true only if neither parents were null here:

dTree-Seed/src/seeder.ts

Lines 179 to 195 in 9e16df8

	marriage.children = data.filter((member) => {
	if (member.parent1Id !== null && member.parent2Id !== null) {
	return marriedCouple.includes(member.parent1Id as number)
	&& marriedCouple.includes(member.parent2Id as number);
	}
	if (member.parent1Id !== null && member.parent2Id === null) {
	return marriedCouple.includes(member.parent1Id as number)
	&& member.parent2Id === null;
	}
	if (member.parent1Id === null && member.parent2Id !== null) {
	return marriedCouple.includes(member.parent2Id as number)
	&& member.parent1Id === null;
	}
	return false;
	}).map((child) => new TreeNode(child, options));
	node.marriages.push(marriage);

then if nuclear, push to node.marriages.children, otherwise push to node.children

Hopefully this helps someone. Javascript is not my forte 😅