Repository navigation
Ignore AGENT_TEST_MODE in jest - #6258
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Jest reads the developer's local config.json, so a machine with AGENT_TEST_MODE on dropped the NotificationView from SceneWrapper and failed five scene snapshots. Mock src/util/agentTestMode in jestSetup.js so the flag reads as off in every test. A test that needs it on still mocks the module itself.
j0ntz
force-pushed
the
jon/jest-ignore-agent-test-mode
branch
from
October 14, 2026 00:03
215f31d to
2e466ae
Compare
j0ntz
enabled auto-merge
October 14, 2026 00:06
Contributor
Author
|
Landing this without a review.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Asana task
Jest reads the developer's local
config.json. WithAGENT_TEST_MODEon there,SceneWrapperdrops theNotificationView, and five scene snapshots fail in four suites:TransactionDetailsScene,SwapConfirmationScene,SwapSuccessSceneandSwapCreateScene. They fail on an untoucheddeveloptoo.jestSetup.jsmockssrc/util/agentTestMode, soisAgentTestMode()returns false in every test.RecoveryReminderActions.test.tsmocks the module itself. A mock in a test file replaces the one from the setup file, and its flag-on cases still run.No app code and no snapshot changes.
I ran
npm test -- --cithree ways.developsetup file and the flag on, the four suites above fail on 5 snapshots.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have: