Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e2f72e557
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A stored payee name outranks the title derived from a transaction's action. The payee picker lists swap providers, so a MoonPay sale labeled from it showed "MoonPay Trade (DeFi)" and read as a swap. A fiat buy or sell now keeps its own title when the stored name is a registered swap provider's display name. Any other stored name still wins, and the stored name is left untouched.
Searching MoonPay in the payee picker listed only the two MoonPay Trade swap providers, so a fiat sale could only be named after a swap. The new entry uses the icon the MoonPay ramp plugin already shows.
j0ntz
force-pushed
the
jon/moonpay-sale-dex-title
branch
from
October 13, 2026 18:11
3e2f72e to
3549870
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A MoonPay sale appeared in a wallet's Recent Transactions as "MoonPay Trade (DeFi)", a swap provider's name, where other sales read "Sell Bitcoin".
The title was a stored payee name. A stored payee name outranks the title derived from the transaction's saved action, and a "MoonPay" search in the payee picker matched only the two MoonPay Trade swap providers.
A swap provider contact picked as the payee of a fiat sale is still saved, but the row and the reopened details scene keep the sale title.
No code path in the app writes a swap provider's name onto a sale by itself. The bug's listed steps did not produce the title without a payee edit. A real MoonPay sale needs identity verification and a fiat payout, and the evidence below comes from an iOS simulator where an existing Bitcoin send was forced to carry a MoonPay sell action and the payee was saved through the real picker. The second batch repeats the drive with both MoonPay Trade swap plugins disabled, so the title holds when the provider is absent from the loaded swap plugins.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Test evidence
3549870Add a MoonPay payee contact
2026-10-13
🪓 Uncommitted, reverted: the newest Bitcoin send was forced to carry a MoonPay sell action (useTransactionList.ts); for frames 05 to 08 both MoonPay Trade swap plugins were also disabled (corePlugins.ts). Not a real MoonPay sale.
1. 🪓 payee search lists moonpay
2. 🪓 before fix sale titled with swap name
3. 🪓 after fix sale keeps sell title
4. 🪓 moonpay payee on sale row
5. 🪓 exchange settings without moonpay trade
6. 🪓 picker still offers unloaded swap contact
7. 🪓 details payee saved as swap contact
8. 🪓 sale keeps sell title plugin not loaded