Repository navigation
Add a testID to the custom token edit icon - #6248
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9bf034f. Configure here.
9bf034f to
36efa20
Compare
Use the shared EditIcon instead of importing FontAwesome directly. The accessibility hint and role move to the touchable, which is the element assistive tech sees: the icon inside it is not a node of its own.
Added id: - manageTokensRow.<currencyCode>.<displayName>.edit (the edit icon on a custom token row) The icon had no id, so a UI test could only reach the Edit Token scene with a coordinate tap. The id carries the display name, as the row id does, because two custom tokens on one wallet can share a ticker.
36efa20 to
8a1f954
Compare
There was a problem hiding this comment.
Claude Code Review
Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.
Tip: disable this comment in your organization's Code Review settings.
|
Landing this without a review.
|

Description
Asana task
Adds a testID to the edit icon on a custom token row in Manage Tokens:
manageTokensRow.<currencyCode>.<displayName>.edit. The id carries the display name, as the row id does, because two custom tokens on one wallet can share a ticker. The icon had no id, so a UI test could reach the Edit Token scene only with a coordinate tap.maestro/07-wallets/C000045-add-edit-tokens.yamlcarries a TODO for exactly this ("need targeting for edit icon").The first commit clears the one lint warning in the file: the row imported FontAwesome directly, and now uses the shared
EditIconfromThemedIcons. The accessibility hint and role move from the icon to the touchable around it, which is the element assistive tech sees.The id is used by the UI flow that proves EdgeApp/edge-currency-accountbased#1117 (a Cosmos wallet refuses its own native denom as a custom token). That flow ran on an iOS simulator against these two commits and opened Edit Token through the new id. This PR stands alone and does not depend on that one.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Low Risk
Small UI/test-harness change on Manage Tokens rows with no auth, payment, or data-handling impact.
Overview
Adds a testID on the custom-token edit control in Manage Tokens (
manageTokensRow.<currencyCode>.<displayName>.edit) so UI tests (e.g. Maestro) can open Edit Token without coordinate taps when multiple custom tokens share a ticker.Replaces the direct FontAwesome edit glyph with the shared
EditIconfromThemedIcons, moving accessibility hint/role to the wrapping touchable.ManageTokensRow.tsxis dropped from the ESLint file override list after that import fix.Reviewed by Cursor Bugbot for commit 8a1f954. Bugbot is set up for automated code reviews on this repo. Configure here.
Test evidence
36efa20test: add testIDs to ManageTokensRow edit icon
2026-10-07
12. osmosis other denom saved
13. osmosis edit to native denom rejected