From 872e78948b329c641f1f93a11d7340dbb05d01de Mon Sep 17 00:00:00 2001 From: Nathan Lovato <12694995+NathanLovato@users.noreply.github.com> Date: Mon, 10 Nov 2025 22:38:08 +0100 Subject: [PATCH] Update the install script and readme to support the new release artifact naming --- README.md | 2 +- get-binary.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 5a6fba3..7238ee4 100644 --- a/README.md +++ b/README.md @@ -14,7 +14,7 @@ The linter runs automatically when you save a file and displays warnings and err ## Requirements This extension ships with the gdscript formatter binary for your specific platform at version `0.16.1` and uses it by default. -If you want to provide your own binary, you can retrieve the one for your platform [here](https://github.com/GDQuest/GDScript-formatter/releases). You can either add it to your system's PATH for autodiscovery or specify the path to the executable in the extension settings (see below). If the binary is added to PATH, make sure to remove the platform and architecture from the filename, e.g. rename `gdscript-formatter-windows-x86_64.exe` to `gdscript-formatter.exe` or `gdscript-formatter-linux-aarch64` to `gdscript-formatter`. Then disable the `useBuiltInBinary` setting. +If you want to provide your own binary, you can retrieve the one for your platform [here](https://github.com/GDQuest/GDScript-formatter/releases). You can either add it to your system's PATH for autodiscovery or specify the path to the executable in the extension settings (see below). If the binary is added to PATH, make sure to remove the version tag, platform and architecture from the filename, e.g. rename `gdscript-formatter-0.16.1-windows-x86_64.exe` to `gdscript-formatter.exe` or `gdscript-formatter-0.16.1-linux-aarch64` to `gdscript-formatter`. Then disable the `useBuiltInBinary` setting. ## Extension Settings diff --git a/get-binary.sh b/get-binary.sh index c56095f..b9cba6c 100755 --- a/get-binary.sh +++ b/get-binary.sh @@ -19,10 +19,10 @@ file_ext="" if [[ "$TARGET" == windows* ]]; then file_ext=".exe" fi -url="https://github.com/GDQuest/GDScript-formatter/releases/download/$VERSION/gdscript-formatter-$TARGET$file_ext.zip" +url="https://github.com/GDQuest/GDScript-formatter/releases/download/$VERSION/gdscript-formatter-$VERSION-$TARGET$file_ext.zip" echo "Downloading gdscript-formatter version $VERSION for target $TARGET at: $url" curl -L --output temp.zip $url && \ unzip -o temp.zip -d binaries && \ rm temp.zip && \ -mv "binaries/gdscript-formatter-$TARGET$file_ext" "binaries/gdscript-formatter$file_ext" \ No newline at end of file +mv "binaries/gdscript-formatter-$VERSION-$TARGET$file_ext" "binaries/gdscript-formatter$file_ext" \ No newline at end of file