Repository navigation
Refactor: Reduce PHPStan baseline by fixing suppressed type errors in src/ #6306
rachana192837
started this conversation in
Ideas
Replies: 1 comment
|
IA |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Summary
The
phpstan-baseline.neoncurrently suppresses a number of pre-existingPHPStan errors to allow CI to pass on legacy code. Some of these ignored
errors are fixable with small, safe refactors — such as adding missing return
types, fixing nullable type hints, or removing unreachable code — without
changing any behaviour.
Goal
Reduce the number of ignored errors in
phpstan-baseline.neonby addressinga targeted subset in
src/, with no functional changes.Motivation
Proposed Scope
Focus on one category of baseline errors per PR, for example:
?Typehints)elsebranches after early returnsEach PR removes the corresponding entries from
phpstan-baseline.neonandconfirms CI stays green.
References
phpstan-baseline.neonphpstan.neon.github/onboarding.mdAll reactions