fix: preserve accurate decoding on software GPUs

Author: richiemcilroy

packages/editor-solid-web/src/browser-decoded-video-pool.ts

@@ -21,8 +21,6 @@ type DecodedSlot = {
 	current: VideoSample | null;
 	upcoming: VideoSample | null;
 	lastRequestedTime: number;
-	streamSamples: number;
-	slowStreamSamples: number;
 	serial: Promise<void>;
 };
 
@@ -67,8 +65,6 @@ async function resetStream(slot: DecodedSlot) {
 	slot.upcoming?.close();
 	slot.upcoming = null;
 	slot.lastRequestedTime = -1;
-	slot.streamSamples = 0;
-	slot.slowStreamSamples = 0;
 	if (iterator) await iterator.return();
 }
 
@@ -112,7 +108,6 @@ async function sampleAtTime(
 
 export class BrowserDecodedVideoPool {
 	private readonly slots = new Map<string, SlotEntry>();
-	private readonly slowSources = new Set<string>();
 	private retainedKeys: Set<string> | null = null;
 	private disposed = false;
 
@@ -155,8 +150,6 @@ export class BrowserDecodedVideoPool {
 				current: null,
 				upcoming: null,
 				lastRequestedTime: -1,
-				streamSamples: 0,
-				slowStreamSamples: 0,
 				serial: Promise.resolve(),
 				retagBt601:
 					config.codec.startsWith("avc1") &&
@@ -212,7 +205,6 @@ export class BrowserDecodedVideoPool {
 		) {
 			throw new Error("Editor video source URL is invalid");
 		}
-		if (this.slowSources.has(url.href)) return "fallback";
 		const key = slotKey(segmentIndex, track, role);
 		let entry = this.slots.get(key);
 		if (entry && entry.url !== url.href) {
@@ -243,13 +235,11 @@ export class BrowserDecodedVideoPool {
 				releaseSerial = resolve;
 			});
 			let sample: VideoSample | null;
-			let decodeStarted = 0;
 			try {
 				await previous;
 				if (signal.aborted || this.disposed) {
 					throw signal.reason ?? new DOMException("Canceled", "AbortError");
 				}
-				decodeStarted = performance.now();
 				sample = await sampleAtTime(slot, sourceTime, stream);
 			} finally {
 				releaseSerial();
@@ -321,17 +311,6 @@ export class BrowserDecodedVideoPool {
 						bitmap.close();
 						throw signal.reason ?? new DOMException("Canceled", "AbortError");
 					}
-					if (stream) {
-						const elapsedMs = performance.now() - decodeStarted;
-						if (slot.streamSamples === 0 && elapsedMs > 250) {
-							this.retireSource(url.href);
-						} else if (slot.streamSamples > 0) {
-							slot.slowStreamSamples =
-								elapsedMs > 100 ? slot.slowStreamSamples + 1 : 0;
-							if (slot.slowStreamSamples >= 2) this.retireSource(url.href);
-						}
-						slot.streamSamples++;
-					}
 					return {
 						bitmap,
 						width: bitmap.width,
@@ -369,15 +348,6 @@ export class BrowserDecodedVideoPool {
 		}
 	}
 
-	private retireSource(url: string) {
-		this.slowSources.add(url);
-		for (const [key, entry] of this.slots) {
-			if (entry.url !== url) continue;
-			this.slots.delete(key);
-			releaseEntry(entry);
-		}
-	}
-
 	retainSegments(primary: number, overlap: number | null) {
 		const wanted = new Set<string>();
 		for (const track of ["display", "camera"] as const) {
@@ -406,7 +376,6 @@ export class BrowserDecodedVideoPool {
 		this.disposed = true;
 		for (const entry of this.slots.values()) releaseEntry(entry);
 		this.slots.clear();
-		this.slowSources.clear();
 		this.retainedKeys = null;
 	}
 }